Merge branch '657-mailroom-webrick-ubi' into '16-4-stable'
What does this MR do?
Merge branch '657-mailroom-webrick-ubi' into 'master'
UBI: Explicitly add webrick gem to mailroom build
Closes #657 (closed)
See merge request !1551 (merged)
Merged-by: Robert Marshall rmarshall@gitlab.com Approved-by: Mitchell Nielsen mnielsen@gitlab.com Approved-by: Robert Marshall rmarshall@gitlab.com Co-authored-by: Jason Plum jplum@gitlab.com
(cherry picked from commit 20a63bfa)
4e355303 UBI: Explicitly add webrick gem to mailroom build
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Integration tests added to GitLab QA -
The impact any change in container size has should be evaluated -
New dependencies are managed with dependencies.io
Merge request reports
Activity
changed milestone to %16.5
assigned to @WarheadsSE
added devopssystems sectioncore platform labels
1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. If from a community member, ask that the Community contribution label be added as well.
Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersGenerated by
DangerI'll take this one too, since I already have all things at hand to test it up after testing it for 16-3 (Merge branch '657-mailroom-webrick-ubi' into '1... (!1555 - merged)).
Edited by João Alexandre Cunharequested review from @Alexand
added workflowin review label and removed workflowready for review label
marked the checklist item When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow as completed
QA
Did the same test as for 16-3 target MR (!1555 (comment 1578871770)), but changed the base image:
global: - gitlabVersion: cherry-pick-20a63bfa-2 + gitlabVersion: cherry-pick-20a63bfa image: - tag: cherry-pick-20a63bfa-2 + tag: cherry-pick-20a63bfa
@rmarshall, I'll assign this one to you as well, since you've approved the default branch MR, and is assigned to the 16-3 stable also.
requested review from @rmarshall
removed review request for @Alexand
Based on @Alexand 's test results, my previous review results, and this being a backport, I am approving.
I believe this falls under the guidelines where I can merge to stable, so, merging too.
mentioned in commit ef572f99
mentioned in issue Alexand/growth-and-development#2 (closed)