Skip to content

gitlab-rails: support skipping post-migrations in db checks

Jason Plum requested to merge rails-deps-skip-post into master

What does this MR do?

gitlab-rails: support skipping post-migrations in db checks

Add support for explicitly bypassing schema post-migrations to wait-for-deps scripting that detects the codebase version.

Add BYPASS_POST_DEPLOYMENT, that will cause the use of checking db/migrate when present. This is in place of db/schema_migrations as db/migrate will only have pre-migrations that are required for the application to start.

Supplemental: large cleanup of outdated code, from prior to 16.0

  • We no longer support schema.rb
  • We no longer use Rake tasks
  • We no longer read structure.sql (as db/schema_migrations or db/migrate will always exist)

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Robert Marshall

Merge request reports