Skip to content

Rails: disable experimental feature warnings

Jason Plum requested to merge rails-suppress-experimental-warnings into master

What does this MR do?

Rails: disable experimental feature warnings

Add RUBYOPT="-W:no-experimental" to the gitlab-rails containers, to suppress extreme list of Ruby warnings on RegEx one-liners in use by many components.

Related to gitlab-org/gitlab#420811 (closed)

Changelog: fixed

Notes

I have additionally triggered the UBI pipeline. As we're not changing any Golang, or underlying runtimes, there was no need to build FIPS.

Test plan

Before: Rails containers start with "wall" of warning: One-line pattern matching is experimental, and the behavior may change in future versions of Ruby!

After: No such output

Testing

Evidence can be seen from the logs of a docker-compose instance. Update .env with IMAGE_TAG=rails-suppress-experimental-warnings

Related issues

Mirrors gitlab-org/omnibus-gitlab!7137 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
  • New dependencies are managed with dependencies.io
Edited by Jason Plum

Merge request reports