Skip to content

Bump golang from 1.19.8 to 1.19.9

Andrew Patterson requested to merge 457-bump-golang-to-1.19.9 into master

What does this MR do?

Bump golang from 1.19.8 to 1.19.9

Related issues

Test plan

Getting the go version used to build a binary.

  1. Run docker container:

    • Debian: docker run -it --rm --user root --entrypoint /bin/bash <container>
    • UBI/FIPS: docker run -it --rm --user root --entrypoint /usr/bin/bash <container>

  2. Install binutils to get the strings command:

    • Debian: apt-get update && apt-get install -y binutils
    • UBI/FIPs: microdnf install -y binutils

  3. Run strings on the binary:

    strings <binary> | grep "^go1\."

Some containers are not bases on debian. In such case use docker cp to copy the binary locally and then run strings on the result.

Confirm debian binaries are built with the correct version of go

  • gitlab-container-registry:/bin/registry
  • gitlab-kas:/usr/bin/kas # Use docker cp
  • gitlab-pages:/bin/gitlab-pages
  • gitlab-rails-ee:/usr/local/bin/gitlab-elasticsearch-indexer
  • gitlab-rails-ee:/usr/bin/gitlab-metrics-exporter
  • gitlab-webservice-ee:/usr/local/bin/gitlab-logger
  • gitlab-zoekt-dynamic-indexserver:/bin/zoekt-dynamic-indexserver
  • gitlab-zoekt-webserver:/bin/zoekt-webserver

Confirm ubi8 binaries are built with the correct version of go

  • gitlab-container-registry:/usr/bin/registry
  • gitlab-kas:/usr/bin/kas
  • gitlab-pages:/usr/local/bin/gitlab-pages
  • gitlab-rails-ee:/usr/bin/gitlab-elasticsearch-indexer
  • gitlab-rails-ee:/usr/bin/gitlab-metrics-exporter
  • gitlab-webservice-ee:/usr/local/bin/gitlab-logger

Confirm fips binaries are built with the correct version of go

  • gitlab-container-registry:/usr/bin/registry
  • gitlab-kas:/usr/bin/kas
  • gitlab-pages:/usr/local/bin/gitlab-pages
  • gitlab-rails-ee:/usr/bin/gitlab-elasticsearch-indexer
  • gitlab-rails-ee:/usr/bin/gitlab-metrics-exporter
  • gitlab-webservice-ee:/usr/local/bin/gitlab-logger

Confirm the GitLab Chart and associated trigger-chart-test pipelines pass

  • debian
  • ubi8
  • fips

Confirm gitlab-logger working as expected via checking review app pod logging output

Check log output from webservice pod for the /var/log/gitlab/production_json.log' log. (shows up as webservice {"component ...`) in combined pod output.

  • debian
  • ubi8
  • fips

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated

Closes #457

Edited by Andrew Patterson

Merge request reports