Skip to content

Add --no-preserve parameter to s3cmd invocation for object storage backups

Christoffer Anselm requested to merge dadummy/CNG:bugfix/object-storage-backup into master

What does this MR do?

Since gitlab-toolbox runs as a non-root user s3cmd cannot chown files or directories. Thus to avoid compatibility issues with S3 buckets where filesystem attributes might have been stored for whatever reason this MR adds --no-preserve to the s3cmd invocation for backups.

Related issues

Closes gitlab-org/charts/gitlab#4213 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated - as a pure compatibility-fix this should not need any documentation
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Christoffer Anselm

Merge request reports