Skip to content

Fix deprecated bundler flags

Stan Hu requested to merge sh-fix-bundler-upgrade-issues into master

What does this MR do?

Previously bundle install was called with the --clean, --deployment, and --without flags, but these are deprecated in favor of using bundle config set --local <flag>.

This is especially important for the --deployment flag since the bundler auto-upgrade mechanism will use the system gem path instead of vendor/bundle if this flag isn't set in the correct way.

You can see that bundler 2.4.6 gets installed properly if we force Gemfile.lock to use 2.4.6: https://gitlab.com/gitlab-org/build/CNG/-/jobs/3713321446.

This change will make it possible to update the bundler version in Gemfile.lock in GitLab Rails without any issues.

Related issues

Relates to gitlab-org/charts/gitlab#4210 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Stan Hu

Merge request reports