Skip to content

Use gitlab-logger tagged version instead of the CONTAINER_VERSION one

David Dieulivol requested to merge ddieulivol-use_gitlab_logger_tag_instead_of_container_version into master

Context

While working on gitlab-org/charts/gitlab#3518 (closed), we are attempting to skip jobs from stages 0-4 in a CNG-mirror pipeline.

Skipping jobs broke gitlab-sidekiq-ee and gitlab-webservice-ee, because they depend on a version of gitlab-logger that was built as part of the current pipeline (i.e. the Dockerfiles for those jobs rely on the CI_PIPELINE_CREATED_AT attribute in the CONTAINER_VERSION).

What does this MR do?

It's first of all a question to know whether we could rely on the gitlab-logger version specified in the variables.yml instead of the version that was built inside the pipeline.

If it's possible to do so, the MR removes the redefinition of GITLAB_LOGGER_VERSION inside the jobs that require it.

Related issues

gitlab-org/charts/gitlab#3518 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated

Merge request reports