Skip to content

gitlab-pages: override version using GITLAB_PAGES_VERSION

Alessio Caiazza requested to merge fix-pages-version into master

What does this MR do?

gitlab-pages makefile tries to get the current version using git. However in CNG we get sources as tarballs and git is not available.

> docker run -it registry.gitlab.com/gitlab-org/build/cng/gitlab-pages:v15.4.0 -- gitlab-pages --version
Begin parsing .erb templates from /etc/gitlab-pages
Begin parsing .tpl templates from /etc/gitlab-pages
1.62.0~beta.0.gunknown

With this commit we make sure we overried the version with the content of GITLAB_PAGES_VERSION.

Related issues

Partially related to gitlab-com/gl-infra/delivery#2599 (closed) - I found this problem reviewing the findings from that issue.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Jason Plum

Merge request reports