Skip to content

Make oauth application creation compatible with hashed secrets

Aboobacker MK requested to merge compatibility_for_hashed_secrets into master

What does this MR do?

We are working on hashing application secrets for complainace reasons, existing check for applications will fail for hashed secrets as direct lookup from database won't work. alternative is to use Doorkeeper::Application.by_uid_and_secret which does hashing logic if the secret is hashed

Related issues

Related to gitlab-org/gitlab#370871 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Aboobacker MK

Merge request reports