Skip to content

Ensure that version and release labels use correct build argument

Hossein Pursultani requested to merge hp-verify-ubi-version-labels into master

What does this MR do?

This MR ensures that all UBI images have the correct version and release labels and the values are passed with the correct ARG via build-arg.

Testing

Check the labels of the following images:

TAG='hp-verify-ubi-version-labels-ubi8'
REGISTRY='registry.gitlab.com/gitlab-org/build/cng'
for _NAME in alpine-certificates cfssl-self-sign gitlab-base gitlab-ruby gitlab-rails-ee; do
  docker image pull "${REGISTRY}/${_NAME}:${TAG}"
  _VERSION=$(docker image inspect "${REGISTRY}/${IMG_NAME}:${TAG}" | jq '.[].Config.Labels.version')
  _RELEASE=$(docker image inspect "${REGISTRY}/${IMG_NAME}:${TAG}" | jq '.[].Config.Labels.release')

  echo "${_NAME}: ${_VERSION}/${_RELEASE}"
done

Related issues

Closes gitlab-org/charts/gitlab#3358 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Integration tests added to GitLab QA
  • The impact any change in container size has should be evaluated
Edited by Hossein Pursultani

Merge request reports