feat(proto): add BulkUpsert to the refresh-token service

InternalOAuthDoorkeeperRefreshTokensService now declares BulkUpsert, which takes 1 to 1,000 of the existing Upsert requests and returns one UpsertResult per record in input order (gitlab-org/gitlab#635782 (closed)). Items are validated per record by the handler, so the interceptor checks only the list bound; one validation case covers it.

The RPC comment says which reasons to retry: CLIENT_NOT_FOUND lands once the client replicates, CLIENT_MISMATCH and INVALID never will. The REASON_CLIENT_MISMATCH comment now describes the token-id case this RPC returns it for. The handler arrives in !991 (merged).

It also carries one follow-up from the review of !1030 (merged): the repository validates events before opening a transaction, so a call with no valid event never reaches the database, and the fold comment is reworded.

Part 7 of 11. The full change is in !959 (closed), the integration MR, kept open for the big picture.

  1. !988 (merged) feat(proto): add BulkUpsertClients and UpsertResult (merged)
  2. !989 (merged) feat(auth): add BulkUpsertClients with per-record results (merged)
  3. !990 (merged) refactor(auth): move the bulk record helpers to internal/batch (merged)
  4. !1010 (merged) fix(auth): decide refresh-token upserts in Go (merged)
  5. !1029 (merged) fix(auth): gate stored rows in one upsert helper and wait on the lock (merged)
  6. !1030 (merged) feat(auth): add a batch path to the refresh-token repository (merged)
  7. !1031 (merged) feat(proto): add BulkUpsert to the refresh-token service <- this MR
  8. !991 (merged) feat(auth): add refresh-token BulkUpsert with per-record results
  9. !992 (merged) feat(auth): add refresh-token BulkDelete
  10. !993 (merged) feat(auth): add refresh-token GetState
  11. !994 (merged) feat(auth): count bulk RPC records by outcome

Previous: !1030 (merged) · Next: !991 (merged)

Edited by Shilpa Kundapur

Merge request reports

Loading
Loading