refactor(no-release): fix minor revive issues

Oleksandr Redkorequested to merge
gitlab-community/gitlab-org/api/client-go:refactor/enable-few-revive-checks into main

Enable and fix the following revive issues:

  • comment-spacings
  • confusing-results
  • error-strings
  • identical-switch-branches
  • increment-decrement
  • indent-error-flow
  • unnecessary-stmt
$ golangci-lint run
config/config.go:1072:49: unnecessary-stmt: switch with only one case can be replaced by an if-then (revive)
gitlab.go:1288:9: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
gitlab.go:1412:63: confusing-results: unnamed results of the same type may be confusing, consider using named results (revive)
gitlab.go:1430:64: confusing-results: unnamed results of the same type may be confusing, consider using named results (revive)
gitlab.go:1444:67: confusing-results: unnamed results of the same type may be confusing, consider using named results (revive)
graphql.go:90:48: comment-spacings: no space between comment delimiter and comment text (revive)
request_options_test.go:106:3: increment-decrement: should replace retryCount += 1 with retryCount++ (revive)
request_options_test.go:313:3: increment-decrement: should replace retryCount += 1 with retryCount++ (revive)
types.go:879:2: identical-switch-branches: "switch" with identical branches (lines 880 and 886) (revive)
9 issues:
* revive: 9

Merge request reports