Skip to content

chore: Update review instructions

This MR updates the review instructions to apply some verbiage tweaks:

  • Gherkin comments are now only suggested for complex tests, with an explicit note that they can be omitted for less complex tests
  • Use of files to write HTTP Responses for mux servers are now only suggested for complex tests, with an explicit note that they can be omitted for less complex responses
  • require is explicitly added as a note to the testify/assert package, since we are ok with contributors using both (we mostly want to avoid t.fatal)

Let me know what you all think!

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading