Add support for usernames in project-level MR approval rules
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
Signed-off-by: Richard Kosegi richard.kosegi@gmail.com
Merge request reports
Activity
Thanks for your contribution to GitLab @rkosegi!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. Improve it or delete it.
added Community contribution workflowin dev labels
assigned to @rkosegi
requested review from @timofurrer
- Resolved by Timo Furrer
@rkosegi thanks for the contribution - changes LGTM. However, do you mind adding some tests to
projects_test.go
?
added 1 commit
- f60f88b2 - Add support for usernames in project-level MR approval rules
added 90 commits
-
f60f88b2...2dd18a8f - 89 commits from branch
gitlab-org/api:main
- f1a1a9fc - Add support for usernames in project-level MR approval rules
-
f60f88b2...2dd18a8f - 89 commits from branch
mentioned in issue gitlab-org/quality/triage-reports#22682 (closed)
added groupenvironments label
added devopsdeploy sectioncd labels
added typefeature label and removed devopsdeploy sectioncd labels
added devopsdeploy sectioncd labels
added 7 commits
-
f1a1a9fc...aaf68e99 - 6 commits from branch
gitlab-org/api:main
- ebd5bb46 - Add support for usernames in project-level MR approval rules
-
f1a1a9fc...aaf68e99 - 6 commits from branch
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer No reviewer available @PatrickRice
(UTC+0)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****started a merge train