Skip to content

Add a builder class and test it

Michał Wielich requested to merge michold-test-build into main

Currently, the ./bin/build script is loading all the data from GitLab API twice [once in JsonGenerator and once in CSVGenerator]. I want to improve its performance by loading it only once. As a first step to achieve that, I exported the building logic into a separate class and added tests to make sure we will not break anything with future changes.

The test is not a unit one because the actual improvement that I want to make happen is to reduce the 8 BlobApi calls [as currently defined in the spec] to 4. I think it's also a good idea to add some (almost) e2e testing in this repo.

TO test this MR, just run ./bin/build and see if the metrics dictionary is still working locally.

The performance improvement will be needed for gitlab-org/gitlab#351471 (closed)

Edited by Michał Wielich

Merge request reports