Skip to content

Adding additional properties to user

Merge Request Checklist

  • Link to an issue
  • Include the proposed fix or feature
  • Include and update tests for the modified code
  • Include a documentation change
  • Add an entry in the Unreleased section of the CHANGELOG

This changes adds the following optional attributes to the user entity in the spec file:

  • has_password: bool
  • display_name: str
  • first_name: str
  • middle_name: str
  • last_name: str
  • email: str
  • comment: str
  • default_warehouse: str
  • default_namespace: str
  • default_role: str

These attributes are the same as Snowflake alter user parameters. They are not validated by Snowflake, so the code also does not validate any inputs.

Notes:

  • The #111 (closed) also requests the default_secondary_roles attribute, but implementing this is much more complicated.
  • I am adding the has_password attribute, which - only and only in the case of set False overwrites the password with NULL. This is a security feature.

Once your merge request is complete, please assign it the Permifrost maintainers using the /assign_reviewer @gitlab-data/permifrost_maintainers placed in a comment for the review cycle. Once the review cycle is finished, the reviewer shall approve the merge request so it can be merged by any Permifrost developer, maintainer, or owner.

Edited by Péter Ring

Merge request reports

Loading