Skip to content

Fix views future privileges is_already_granted check

moreaupascal56 requested to merge moreaupascal56/permifrost:fix-view_already_granted-fetching-write-privileges into master

Merge Request Checklist

  • Link to an issue
  • Include the proposed fix or feature
  • Include and update tests for the modified code
  • Include a documentation change
  • Add an entry in the Unreleased section of the CHANGELOG

Add a description of changes implemented here. If more than one issue will be resolved by this MR, please add them at the bottom of description in the format of:

  • closes #
  • closes #
  • etc.

To check if the SELECT privileges have already been granted to views we were checking if the write privileges ere granted (probably a typo). Just fixing that.

This will partially fix the particular example use-case of @zxu4 in #139 (abt views) but there is some other privileges that are always showed in the --dry runs (and that we run at every permifrost runs) like if a user is enabled etc. I think we should open another issue to

Once your merge request is complete, please assign it the Permifrost maintainers using the /assign_reviewer @gitlab-data/permifrost_maintainers placed in a comment for the review cycle. Once the review cycle is finished, the reviewer shall approve the merge request so it can be merged by any Permifrost developer, maintainer, or owner.

Merge request reports