Skip to content

fix: Upgrade `gitaly` and `praefect` tls configurations structure

Furhan Shabir requested to merge fix/upgrade_gitaly_and_praefect_tls_config_structure into master

What

  • Upgrade gitaly and praefect configuration keys for tls to use new scheme, introduced as of Gitlab 15.10
  • Update rspec tests for gitaly and praefect configurations to check new key paths
  • Update praefect database configration keys and rspec test to reflect updated key paths
  • Bump gitlab-secrets dependency version to match an existing version

Why

  1. We are trying to deploy Gitlab omnibus packages 16.0.x as of April 24, 2023 and the following configurations are to be removed

  • praefect['certificate_path']

  • praefect['key_path']

  • gitaly['certificate_path']

  • gitaly['key_path']

    and should be nested under ['configuration']['tls'] instead.

    This is breaking deployment in pre and will break deployments in other environments too.

  1. praefect database configurations also now reside under praefect['configuration']['database'] and hence should be updated in omnibus cookbook along with test specs.

New reference configurations:

Reference issues:

Edited by Furhan Shabir

Merge request reports