Add Joao Cunha as DB maintainer
Trainee maintainer issue: #6611 (closed)
Overview
- GitLab employee since January 2019 (+3 years)
- +200 gitlab-org merged MRs
- +60 database reviews
- Maintainer of:
- https://gitlab.com/gitlab-org/cluster-integration/auto-build-image
- https://gitlab.com/gitlab-org/cluster-integration/cluster-applications
- https://gitlab.com/gitlab-org/project-templates/cluster-management
- https://gitlab.com/gitlab-org/terraform-images
- https://gitlab.com/gitlab-org/configure/k8s-agent-qa
Examples of reviews
- Main concepts
- Schema changes
- Query optimizations
- Background Migrations / Data Migration
- N+1 Related
Becoming a Maintainer
I acknowledge that I still have so much to learn regarding the database knowledge space. Being part of the database trainee process has unquestionably helped me a lot in ramping up on this subject. So I'm already really grateful for it. The last few months I've been feeling more and more confident about being a DB maintainer because I've seen much less post-review comments, and most the post-reviews comments were not critical to the database performance. Furthermore, I feel like I've been able to recognize the situations where I don't have the necessary knowledge to take the final decision, thus calling someone else for a second opinion is necessary.
@gitlab-org/maintainers/database please chime in below with your thoughts, and approve this MR if you agree.
Things to improve
-
Finding the most relevant dataset. Sometimes it's straight forward to get
gitlab-org/gitlab
id or some user's id with a lot of contributions. But sometimes the correct data requires a bit more creative investigation. I really liked what Mayra did here to help me find the best dataset recently. - More experience optimizing or helping write complex queries
- Paying more attention to process improvement opportunities
Strengths
- Clear communication with authors through detailed comments and references to our documentation
- Thorough reviews by trying to analyze queries for different dataset scenarios, thinking about .com vs self-managed impact, as well as backwards compatibility impacts
- Recognizing situations when a second opinion is necessary
- Suggesting follow-up issues for existing problems found throughout reviews
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/database
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Consider adding 'database maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-