Skip to content

Company team page optimisations

Kos Palchyk requested to merge kpalchyk/company-team-page-optimizations into master

Why is this change being made?

This MR optimises https://about.gitlab.com/company/team/ page size, reducing the html sent over network from 6.4Mb to 4.2Mb (542K to 494K gzipped).

The reduction is primarily achieved by moving an inlined <svg>...</svg> to an image <img src="logo.svg"/>. MR also removed an empty <h4></h4> that was duplicated across all records. Currently, there are ~ 1600 records, which adds up to a significant size overhead.

This reduction should also optimise parsing speed and initial page rendering (although I can only verify it on staging).

This change affects following pages:

NOTE: due to technical restrictions a minor UI change was introduced:

before after
previously all icons for links to GitLab profile were colourful by default and violet on hover (top right icon hovered) now the icon is grayscale by default and becomes colourful on hover (top right icon hovered)
Screenshot_2021-12-17_at_23.16.03 Screenshot_2021-12-17_at_23.17.13

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this change to the correct DRI(s)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR.
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Tyler Williams

Merge request reports