Skip to content

Clarify work in progress for FCLs

Nicolas Dular requested to merge nicolasdular-master-patch-79409 into master

Why is this change being made?

During a recent FCL, engineers asked how to deal with MR reviews that got assigned to them before the FCL. The wording “any other type of work in-flight has to be paused” is clear but seems to still leave open questions. I believe this is because as a reviewer/maintainer you feel some responsibility for driving the MR and having impact on the results of other teams.

I think it would be worth to clarify what it means even further but not only tie it to code reviews.

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this change to the correct DRI(s)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR.
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Nicolas Dular

Merge request reports

Loading