Graduate Andy Soiron to backend maintainer
Trainee maintainer issue: #10167 (closed)
Overview
Hey GitLab backend maintainers, I'm Andy, Senior Backend Engineer on ~"group::ecosystem". I'm a GitLab team member since November 2019. I got 111 MRs merged on GitLab and started my trainee maintainer training 7 months ago. Since then, I did 74 backend reviews, 51 of the MRs got merged as-is after my review (69%). I'm also a database trainee maintainer.
Examples of reviews
Here are a few interesting reviews:
- gitlab-org/gitlab!66466 (merged) (Database and validation suggestions)
- gitlab-org/gitlab!60828 (merged) (Rapid action, architectural discussion about internal API)
- gitlab-org/gitlab!61399 (merged) (Mostly asking questions to get a better understanding)
- gitlab-org/gitlab!54778 (merged) (Adding a new gem)
Things to improve
- I can improve my knowledge about EE architecture. Here is an example where I missed suggesting some changes.
- As a maintainer, I would need to ask more question if a change is unclear to me to get a better understanding because there is no other review after me.
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Andy Schoenen