Add vshumilo as backend maintainer for CustomersDot and LicensesDot
Trainee maintainer issue: https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/10127
Overview
- Overall GitLab experience: 1yr and 2 months 163 MRs merged
- Trainee Backend Maintainer issue (customers-license): https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/10127
- Authored MRs within CustomersDot.
- Authored MRs within LicensesDot.
Examples of reviews
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/2945
- https://gitlab.com/gitlab-org/license-gitlab-com/-/merge_requests/263
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3211
- https://gitlab.com/gitlab-org/license-gitlab-com/-/merge_requests/271
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3233
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3247
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3252
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3261
- https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/3285
Things to improve
Note to self: MRs where not all the changes are displayed or with multiples VCRs are more challenging to review without checking out the branch locally.
I have incorporated checking the branch locally as part of my review routine for any change that is not super short or straightforward to review inline.
Please let me know about any other areas where I should or can improve
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
cc. @cwiesner @jameslopez @rdavila @shreyasagarwal @tyleramos
Please chime in below with your thoughts, and approve this MR if you agree.
Edited by James Lopez