Skip to content

Add Product Designers as UX reviewers of GitLab

Pedro Moreira da Silvarequested to merge
pedroms-master-patch-49735 into master

Why is this change being made?

This change formalizes the long-standing practice of Product Designers reviewing user-facing changes, as documented in https://docs.gitlab.com/ee/development/code_review.html#approval-guidelines

In addition, it will help MR authors find the appropriate reviewers in:

  1. https://docs.gitlab.com/ee/development/code_review.html#approval-guidelines
  2. https://about.gitlab.com/handbook/engineering/projects/#gitlab

Related to gitlab-org/gitlab-design#1489 (closed)

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files. (this requirement has been removed pending identification of a new DRI for the handbook)
Edited by Pedro Moreira da Silva

Merge request reports