Add dgruzd as a backend maintainer
Trainee maintainer issue: #6765 (closed)
Overview
I've been a Senior Backend Engineer on the Global Search team since December 2nd, 2019.
Since my joining the team and company, I have been working on the following things:
- Implemented routing usage for most Elasticsearch calls with a great performance boost
- Implemented multiple storage improvements measures that reduced around 80% of the total Elastic index size
- Participated in Global Search rollout for all paid customers on GitLab.com
- Improved basic and global search performance on many occasions, including ES queries tuning and N+1
- Author of the Zero-downtime reindexing feature (backend and UI)
- Authored the Global Search background migration framework, which our team has successfully been using to migrate document types into separate indices (issues, for example)
- Adapted sharded approach for our indexing process to decrease the load on Redis and lay the groundwork for parallel indexing.
I have also been a database reviewer for several months now.
Some contribution related stats (authored + reviewed MRs):
Examples of reviews
- https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/1127#note_472174346 - Suggested creating a spec to protect us from reintroducing this security vulnerability in the future
- gitlab-org/gitlab!43083 (comment 418033625) - Suggested using a feature flag and posted my local performance benchmarks
- gitlab-org/gitlab!36255 (comment 375536551) - Provided a storage impact assessment
- gitlab-org/gitlab!46646 (comment 440559753) - Suggested extracting sorting logic into a shared method with code examples
- gitlab-org/gitlab!29952 (merged) - Interesting review, had a lot of suggestions
Things to improve
- I think that my GraphQL knowledge is still pretty limited. This means that for GraphQL changes I'd need to ask for help and invest more time into developing this knowledge.
- Frontend - I have only basic JavaScript and Vue skills, most of frontend work that I've done is haml views.
- There are some parts of GitLab codebase that I've never touched, but I'm not sure that it's really possible given its current size.
- Sometimes I notice something during a review, but fail to mention it thinking that it's not important.
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Dmitry Gruzd