Skip to content

Add image_url validation in release post item linter

Achilleas Pipinellis requested to merge axil/rpi-validate-image_url into master

Why is this change being made?

Some images might be committed in the wrong place, and sometimes the image_url is missing the leading slash (/), which results in the final assembly the image being broken.

Since the assembly script seems to be following a strict rule, we can solve this by checking that the image_url always starts with /images/unreleased/.

Tested locally with a wrong image_url:

./bin/validate-release-post-item data/release_posts/13_6/brakeman-severity.yml
error data/release_posts/13_6/brakeman-severity.yml: image_url should start with /images/unreleased/

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files. (this requirement has been removed pending identification of a new DRI for the handbook)
Edited by Achilleas Pipinellis

Merge request reports