Skip to content

Add Ammar Alakkad as a frontend maintainer for CustomersDot

I started actively reviewing MRs for CustomersDot on Oct 4, 2019. During this time I've learned a lot and worked on bridging many gaps, from being more iterative to taking better care of testing.

Since I began working on CustomersDot in July 2019, I've reviewed over 75 MRs and contributed 150+ merged MRs.

I enjoy collaborating with our UX and backend counterparts, e.g. collaborating with the UX team during Pajama's project.

I'm still working on learning more about advanced GraphQL, learned about smart queries during this review.

Trainee frontend maintainer issue.

Initiatives

Links to Non-Trival MRs I've Reviewed

Provided a short review summary under each item.

suggestions about consistent default values with prop type, shorten variable names, use v-safe-html with defined allowed tags

suggestions about using GitLab's utility classes, matching the provided design

suggested merging <hr> within a child component and a prop to control it to reduce code redundancy

Provided a patch to enhance frontend tests, and another patch to fix a feature flag issue for a backend MR

Had a suggestion for the UX which got accepted, suggested component-specific style to be in a dedicated .scss file, suggested renaming scss selector to not inherit unwanted styles

Noticed MR removed an id which would break the corresponding label, noticed adding required to a not required field.

Links to Non-Trivial MRs I've Written

Used skeleton component under a feature flag followed by another MR to replaced the placeholder

Add plumping between introduced change and parent component with a feature spec covering it


@kushalpandya @mikegreiling @ntepluhina @pslaughter @rhardarson @vitallium @wortschi please chime in below with your thoughts, and approve this MR if you agree.

Closes gitlab-org/customers-gitlab-com#733

Edited by Ammar Alakkad

Merge request reports