Request to make Mark Chao a Maintainer on gitlab repo
/label backend trainee maintainer
Trainee maintainer issue: #5061 (closed)
Overview
GitLab expericense:
- 2 years 3 months.
- 114 MRs authored
- Have experience in plan/issue, create/merge request, search, editor/snippet and knowledge.
Examples of reviews
- gitlab-org/gitlab!29897 (merged) (pointed a few Ruby idioms, possible nil exception, and possibility for DRY)
- gitlab-org/gitlab!30726 (merged) (suggesting to combine services)
- gitlab-org/gitlab!25383 (merged) (Suggested bug related to dynamic string interpolation was used incorrectly as i18n key)
- gitlab-org/gitlab!26922 (merged) (Spotted bug related to regular expression edgecase)
- gitlab-org/gitlab!36256 (merged) (Suggested to instead of removing the validation, we try to validate ref as branch names too.)
Things to improve
-
gitlab-org/gitlab!33869 (merged)
- I was familiar with the topic and wasn't so strict on requesting a verification (such as demo project for CI/CD).
-
gitlab-org/gitlab!36667 (merged)
- I should have inspected outside the diff, which would indicate the code is applicable to EE only.
-
gitlab-org/gitlab!26922 (merged) (Spotted bug related to regular expression edgecase)
- I didn't invest enough on double checking the requirements.
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by James Lopez