Skip to content

Assign "required MR approval" feature to SCM category only

Daniel Gruesso requested to merge source-code-required-approvals into master

Why is this change being made?

Assign "required MR approval" feature to SCM category only. Currently it sits in both Source Code Management and Code Review, however, from a persona POV, it is neither author nor reviewer who is setting these up but rather the repository maintainer, and thus belongs more appropriately to source code management

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per [say-why-not-just-what][transparency]
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to your manager.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in [#mr-buddies][mr-buddies-slack].
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files.

Merge request reports