Make Yannis Roussos a database maintainer

Background

• GitLab employee since April 2018 (~2 years and 4 months)
• Database trainee maintainer for ~5 months - #6925 (closed)

Database Trainee

• Reviewed 80+ Database merge requests

  • 56 of the MRs I have reviewed were also approved by the database maintainer with no further updates requested

• Some process/documentation improvements:

  • Add handbook page on Database Reviewer Onboarding
  • Add database guides for NOT NULL constraints
  • Update database guides on text data type usage
  • Add info on using reset_column_information to the Data Migration Guide

• Some database improvements:

  • Migration helpers for managing generic check constraints and Migration helpers for adding limits to text columns

  • Migration helpers for managing NOT NULL constraints.

    Also in the same MR: update the disable_statement_timeout migration helper to allow calling it multiple times, even from inside a block of another disable_statement_timeout, without resetting the timeout before the outer block finishes.

  • Various database related Rubocop updates: gitlab-org/gitlab!28690 (merged), gitlab-org/gitlab!29304 (merged), gitlab-org/gitlab!34056 (merged)

Becoming a maintainer

I have learned a lot during the period I am doing Database reviews and I feel that I have become a better and more thorough reviewer thanks to all the additional comments by the db maintainers in the MRs that I have participated.

There is still a lot more to learn, especially as GitLab grows at the pace it does, but at least I am at a point where I understand the complications of our database size, deployment processes and different types of installations and how they affect the database updates that we roll out.

I am more than happy to take more database responsibilities and, with 14 new database reviewers and 3 database trainee maintainers, I feel that I should take the leap, level up and help with the maintainer reviews and any other way I can.