Add Patrick Bajao as backend maintainer
/label backend trainee maintainer
-
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
Trainee maintainer issue: #4798 (closed)
Overview
I've been a backend engineer at GitLab since January 14, 2019 (~1 year and 7 months).
In that duration, I've authored 163 merged MRs in gitlab-org.
I've been a backend traintainer for GitLab project since July 16, 2019 (over a year now) with the primary intention of learning more about the project and the codebase. I'm also maintainer of gitlab-shell and a trainee maintainer of gitlab-workhorse.
During the traintainer process, I was able to review 22 listed backend merge requests. There's actually more but some of them were very simple, small MRs and weren't included in the traintainer issue. I've learned a lot during the process from ensuring that change log entries are required when needed, making sure MRs aren't too far from master
(this was before merged result pipelines), etc, up to reviewing some parts of the product that I haven't touched or seen.
I feel ready to be a backend maintainer but would also like to hear feedback that could help me improve.
Examples of reviews
- #4798 (comment 193634062)
- #4798 (comment 196173354)
- #4798 (comment 199220984)
- #4798 (comment 247475020)
- #4798 (comment 287363896)
- #4798 (comment 311808920)
- #4798 (comment 327166447)
- #4798 (comment 327176957)
- #4798 (comment 373180576)
Things to improve
- Keep in mind database implications even though there's a database reviewer/maintainer that will review them.
- Check that method calls being changed are safe.
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Once This MR is Merged
-
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords -
Manager: Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed