Skip to content

Approvals align better with image in the Release Post

John-Mason Shackelford requested to merge patch-19826112268859191 into master

Why is this change being made?

Sid requested that we change approvers to approvals in https://gitlab.slack.com/archives/C3TRESYPJ/p1592778530355600.

Both statements (approvers and approvals) are technically correct as we now show approvers that we may not have shown before as well as approval numbers in column. In the release post image the red highlight is around the approval numbers column. The release post itself points out that the contributions of these approvers had previously been omitted.

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to your manager.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files.

For help with failing pipelines reach out in #mr-buddies in Slack

Merge request reports