Skip to content

Add BE maintainer (customers-license) - Shreyas Agarwal

Shreyas Agarwal requested to merge 5964-trainee-be-maintainer-customers-license-shreyas-agarwal into master

Why is this change being made?

Overview

Trainee issue: #5964 (closed)

I have been working with Gitlab and especially with customers and license application for more than 6 months now. Since Dec 2019, I have been a trainee for the maintainer for customers and license application. Over this time I have reviewed almost 50 Merge Requests.

Lately, most of them were merged as is after the review was provided and approved and passed to the maintainers. Got a lot of learning on how to do a better review and hopefully more to come.

  • Performed almost 51 reviews for customers and license application
  • 37 were "Merged as-is"
  • Performed 36 Merged request in total till now

Some example reviews

Things to improve

  • Call for another reviewer or team if not sure about the changes.
  • Pull the review branch and test locally if everything is OK if suggesting a review and then note down suggestions.
  • Point for "Praise" if something is done beyond what was needed.

@tyleramos @JamesLopes @rdavila @oswaldo @asubramanian1 What do you think?

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the change relates to any part of the project other than updates to content and/or data files (e.g. team.yml) please make sure to ping @gl-static-site-editor in a comment for a review and merge.
    • If the DRI for the page/s being updated isn't immediate clear, then assign it to your manager.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies

For help with failing pipelines reach out in #mr-buddies in Slack

Closes #5964 (closed)

Edited by Shreyas Agarwal

Merge request reports