Skip to content

Add Markus Koller as backend maintainer

Markus Koller requested to merge toupeira-master-patch-34184 into master

Why is this change being made?

Overview

Trainee issue: #5207 (closed)

  • I've been at GitLab since May 2019 (just a bit over a year now! 🍰)
  • I started contributing in 2017 at my previous job, where I also managed our self-hosted GitLab instance.
  • I authored around 140 merge requests in gitlab-org.
  • The trainee issue has been open for 8 months and has 54 reviews. There's a gap from December to February due to vacations, 🔴 usage, and also Roulette somehow refusing to assign me anything for a couple weeks 😉

Most of my trainee maintainer reviews were merged as is or with minor comments. A lot of the feedback from the maintainers revolved around focusing on specs, and I definitely started to pay closer attention to them over the past few months and feel pretty confident in most of my reviews now.

I feel ready to be a backend maintainer but would love to hear feedback that could help me improve if others disagree.

@gitlab-org/maintainers/rails-backend What do you think?

Example reviews

MRs that introduce non-trivial changes (architectural changes, refactors, developer experience upgrades)

MRs that improve our quality of product (tests, performance)

MRs that deliver full features (ideally this is done iteratively, so a good maintainer can guide someone to break down large MRs to smaller ones)

MRs from community contributors

Things to improve

  • Review more community contributions.
  • Review spec changes more closely.
  • Keep a closer eye on cop usage, and opportunities to add/tweak cops.
  • Be more proactive about pulling in domain experts when I'm unsure.
  • Do more exploratory testing for larger changes, if other reviewers haven't already done so.

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the change relates to any part of the project other than updates to content and/or data files (e.g. team.yml) please make sure to ping @gl-static-site-editor in a comment for a review and merge.
    • If the DRI for the page/s being updated isn't immediate clear, then assign it to your manager.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies

For help with failing pipelines reach out in #mr-buddies in Slack

Edited by Markus Koller

Merge request reports