Skip to content

Refactor handbook-specific templates and style use

Derek Knox requested to merge 6853-handbook-css-styles.css.scss into master

Why is this change being made?

The reason is twofold:

  1. All pages were previously loading unused styles that were intended to be specific to handbook pages
  2. The various handbook layout templates didn't explicitly load these handbook specific styles

A detailed audit of template, style, and JavaScript use is referenced in the related issue.

Before and after test samples:

  • handbook-page-toc

    • /handbook/about
    Before After
    localhost_4567_handbook_about-before localhost_4567_handbook_about-after

  • markdown_page

    • /pricing/premium
    Before After
    localhost_4567_pricing_premium-before localhost_4567_pricing_premium-after

  • default

    • /training
    Before After
    localhost_4567_training-before localhost_4567_training-after

  • release

    • /handbook/marketing/blog/release-posts
    Before After
    localhost_4567_handbook_marketing_blog_release-posts-before localhost_4567_handbook_marketing_blog_release-posts-after

  • job_family_page

    • /job-families/alliances/alliances-manager
    Before After
    localhost_4567_job-families_alliances_alliances-manager-before localhost_4567_job-families_alliances_alliances-manager-after

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the change relates to any part of the project other than updates to content and/or data files (e.g. team.yml) please make sure to ping @gl-static-site-editor in a comment for a review and merge.
    • If the DRI for the page/s being updated isn't immediate clear, then assign it to your manager.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies

For help with failing pipelines reach out in #mr-buddies in Slack

Edited by Derek Knox

Merge request reports