Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
www-gitlab-com
www-gitlab-com
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2,153
    • Issues 2,153
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,250
    • Merge Requests 1,250
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.com
  • www-gitlab-comwww-gitlab-com
  • Merge Requests
  • !47628

Merged
Opened Apr 24, 2020 by Amy Qualls@aqualls✏Maintainer0 of 2 tasks completed0/2 tasks

Docs: add yamllint config for testing

  • Overview 19
  • Commits 12
  • Pipelines 19
  • Changes 34

Why is this change being made?

Axil wrote:

This changes the way yamllint is run. Previously, it was run as part of the lint 1 2 job and the script was defined in package.json. The thing is, although the test ran and showed as successful (example), that was not the case. yamllint wasn't installed at all in order to run, so I have no idea why running this script with yarn yielded a successful outcome.

So, I moved the test into the Rakefile where we also have a bunch of other YAML linters (custom ones), since it made more sense. It's now run as part of the lint 0 2 job, which runs all the lint tasks. For that to happen, we also had to (really) install yamllint, and this was done in the upstream Docker image we use:

  1. First attempt to just install the package , which installed a very old version that didn't recognize our config file with the rules.
  2. Second attempt that installed a newer package that fits our needs.

Amy wrote:

This MR adds a .yamllint.yml file to the root directory of the www-gitlab-com repository, as described in https://yamllint.readthedocs.io/en/stable/configuration.html to provide the default configuration, and then override it in a second commit to disable the following rules:

  • https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.document_start
  • https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.line_length

These rules are overwhelming the results and are obscuring other issues, so they should be disabled for now.

Related to #7212 (closed) where we are considering implementing yamllint.

Does this MR meet the acceptance criteria?

Assign to DRI

  • Did you assign this change to the correct DRI of the page or information you are changing?

Conformity

  • Added description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
Edited Jul 10, 2020 by Marcel Amirault
Assignee
Assign to
Reviewer
Request review from
13.1
Milestone
13.1 (Past due)
Assign milestone
Time tracking
Reference: gitlab-com/www-gitlab-com!47628
Source branch: docs-7212-yamllint-config

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.