Add Krasimir Angelov as database maintainer

Trainee maintainer issue: #4942 (closed)

Overview

GitLab employee since March 2019, trainee maintainer since August 2019. This is my second attempt to become maintainer, the original MR description can be found bellow. The important discussion from this previous attempt is here.

I think I am ready to take the next step and become a Database maintainer.

Examples of reviews

I have reviewed > 100 MRs during my training. In the last few months pretty much all of them were approved by maintainers either as-is, or with some minor comments.

Here are some examples where I worked with MR authors in order to help them achieve their goals in a performant way:

• Add SecuritySetting to Projects
• Add alternative way of importing notes to GitHub Importer
• Create BannedUser table
• Relate Test Reports and Requirement Issues
• Sync the maven metadata file upon package deletion
• Add hidden status to packages

Based on previous feedback from !44110 (comment 308737474), I've been focused on providing timely reviews to Community contribution MRs and help authors getting them merged, while maintaining our standards:

• Migrate existing U2F registrations to WebAuthn
• Steal MigrateU2fWebauthn background migration
• Create Packages from Go module versions
• Show topics in the project list

During my time as a reviewer I have learned a lot, both about the way we aim to execute database changes here at GitLab, and also about PostgreSQL itself, for example how to read and understand execution plans, and how to optimize queries. Some of this knowledge I've tried to give back as updates to our documentation:

• Update "Understanding EXPLAIN plans" docs
• Update docs on comparing execution plans when optimizing queries
• Add section about the #database-lab channel to "Understanding EXPLAIN plans" docs
• Update #database-lab docs

I have also made some small changes to migrations helpers:

• Improve add_concurrent_foreign_key to support custom target column
• Update with_lock_retries to better control the way it works

ans also few more related to the PK migration to bigint, though this was part of my daily job as a temporary member of the Database team.

Things to improve

PostgreSQL (and databases in general) is a topic so wide, I don't think I'll ever run out of things to improve. Every review can be a opportunity to learn something new and build on top of previous experience.

Similarly, the process we have at GitLab around database changes is quite elaborate and constantly changing, so one should always aim to be up to date.

Finally, I am happy that I can always rely on the support of the @gitlab-org/maintainers/database team when I need it.

Please chime in below with your thoughts, and approve this MR if you agree.

Developer checklist

• Before this MR is merged
  • Mention @gitlab-org/maintainers/database, if not done (this issue template should do this automatically)
  • Assign this issue to your manager
• After this MR is merged
  • Consider adding 'database maintainer' to your Slack notification keywords

Manager checklist

• Before this MR is merged
  • The MR has been open for 5 working days
  • More than half of the existing maintainers approve the MR
  • There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
• After this MR is merged
  • Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed

Version history

v1

Background

• GitLab employee since March 2019 (~12 months)
• Database trainee maintainer for ~6 months - #4942 (closed)

Database Trainee

• Reviewed 50+ Database merge requests
• Contributed to documentation for #database-lab - gitlab-org/gitlab!20014 (merged), gitlab-org/gitlab!25218 (merged)
• Contributed performance improvements, e.g. gitlab-org/gitlab!21092 (merged)

Becoming a maintainer

I think I am ready to take the next step and become a Database maintainer.

Given how big the database domain is there will always be something new to learn, but with the support of our awesome team I am confident I'll be able to provide value and help with the issues we face and the features we need to deliver.

Closes #4942 (closed).