Make Jarka BE maintainer
Trainee issue: #3743 (closed)
Overview
- I've been with GitLab more than 3 years, Discussion -> Plan -> Portfolio Management team, promoted to Senior Engineer in August 2019
- During this time I authored almost 300 merge requests (+ security fixes on dev), most of them received no big suggestions during the code review phase at least last few months
- Although the trainee issue was opened 1 year ago, I started getting more reviews about a half year ago
- I have reviewed about 20 MRs last last 3 months, the vast majority of them got merged with no or minor comments/changes.
Code reviews
I feel pretty confident last about 2-3 months. I try to make sure we (with just few examples):
- keep code clean - gitlab-org/gitlab!23236 (comment 273068501), gitlab-org/gitlab!18239 (comment 228566753)
- also keep specs clean - gitlab-org/gitlab!23236 (comment 273068506), gitlab-org/gitlab!20161 (comment 249762684)
- keep consistency in code style - gitlab-org/gitlab!21220 (merged), gitlab-org/gitlab!19947 (comment 248415336)
- discuss more general classes design, avoid code duplication - gitlab-org/gitlab!18946 (comment 237424703)
Things to improve
Sometimes I feel I could ask more questions to clarify things but I think I have improved this a lot last few months. Same goes for checking pipeline status.
I'd like to see thoughts from @gitlab-org/maintainers/rails-backend