Skip to content

Make James Fargher a BE maintainer

James Fargher requested to merge patch-19826111758 into master

Trainee maintainer issue: #5224 (closed)

I think I would have worked with enough maintainers to achieve quorum, but just in case here are what I think would make me a good maintainer:

Based on the feedback I've received so far, here is where I think I'm weakest:

  • I tend to miss changelog wording.
  • I'm inconsistent at calling up code readability issues like needing whitespace (This has at least cause me to fix some rubocop todos gitlab-org/gitlab#34182 (closed))
  • When I review larger MR's I still get a lot post review of feedback. Not often major issues, but something to consider.

In addition I may need to think about limiting time I spend reviewing to make sure I get my own work done too. Review workload varies and 🔴 helps a lot.

For your consideration @gitlab-org/maintainers/rails-backend

Closes #5224 (closed)

Merge request reports