Make Adam Hegyi DB maintainer

Background

• Joined GitLab about 8 months ago.
• DB trainee maintainer in the last 6 months - #4846 (closed)

As Database Trainee

• Reviewed about 50+ Database related MRs.

  SELECT count(DISTINCT notes.noteable_id)
  FROM "notes"
  WHERE (note_html LIKE '%LGTM%')
    AND "notes"."author_id" = 4156052
    AND "notes"."noteable_type" = 'MergeRequest'
    AND "notes"."noteable_id" IN
      (SELECT "merge_requests"."id"
       FROM "merge_requests"
       INNER JOIN "label_links" ON "label_links"."target_id" = "merge_requests"."id"
       AND "label_links"."target_type" = 'MergeRequest'
       INNER JOIN "labels" ON "labels"."id" = "label_links"."label_id"
       WHERE "merge_requests"."target_project_id" IN (278964,
                                                      13083)
         AND "labels"."id" = 3098698);

• Actively present on #database slack channel and answering questions.

• Improved the database docs:

  • https://docs.gitlab.com/ee/development/sql.html#reliably-referencing-database-columns
  • https://docs.gitlab.com/ee/development/migration_style_guide.html#dropping-a-database-table

• Improved the database migration process:

  • https://docs.gitlab.com/ee/development/migration_style_guide.html#retry-mechanism-when-acquiring-database-locks

• Did several performance optimizations that involved database specific changes:

  • gitlab-org/gitlab!18180 (merged)
  • gitlab-org/gitlab!20833 (merged)
  • gitlab-org/gitlab!20970 (comment 261434267)
  • gitlab-org/gitlab!20848 (comment 262505384)

Becoming DB Maintainer

I think I am ready. Recently I had a chat with @abrandl and @mayra-cabrera and they were both supportive about me becoming a DB maintainer. We currently have 3 DB maintainers and as the company grows, we'll need more people on board to reduce the database review cycle times and ease the load on the current maintainers. I like helping others with database specific issues and performance concerns. I think I can help growing GitLab further, keep things running and performing well. During review I might miss things and I might ping other maintainers for help.

Thanks!