Make Andrew Fontaine a Frontend Maintainer (!38445) · Merge requests · GitLab.com / www-gitlab-com

Andrew Fontaine requested to merge afontaine-frontend-maintainer into master Jan 14, 2020

Why is this change being made?

After a year of reviewing merge requests and writing code, as well as 3 months of trainee maintainership, I believe I have reached a level of review capable of being a maintainer! My reviews can be seen in my trainee maintainer issue.

closes #5361 (closed)

The Section of Big Reviews: A Collection of Links to Discussions in the Maintainer Trainee Issue

Resolve "Evidence collection for Releases": #5361 (comment 250065274)
Add informational message about pagination thresholds to the Environments Dashboard page: #5361 (comment 271408673)
Resolve "Extract DiffDiscussionHeader component from NoteableDiscussion": #5361 (comment 244890741)
Resolve "Version dropdown goes wrong if versions are not monotonic": #5361 (comment 253477831)

Ongoing Reviews

feat: Add Collapse component: gitlab-org/gitlab-ui!940 (merged)
Geo Node Form in Vue - Core Fields: gitlab-org/gitlab!23479 (merged)

The Section Of Big Things ™️ I've worked On (Sorted, date descending)

Adding the ability to easily toggle a feature flag on or off

Split to keep reviews small and fast

Allowing Feature Flags to be toggled via user IDs

Initial Implementation: gitlab-org/gitlab!14596 (merged)
Later refactor for better UX: gitlab-org/gitlab!19399 (merged)

Allow copy-paste buttons to work in `vue_shared` modals

Not big, but nice

gitlab-org/gitlab-foss!28676 (merged)

Building out the environments dashboard

Includes refactoring the Operations dashboard for re-use (although I am sure there's much more re-use to be found still)

Does this MR meet the acceptance criteria?

Conformity

Added description to this MR explaining the reasons for the proposed change, per say-why-not-just-what

Edited Jan 22, 2020 by Andrew Fontaine

Make Andrew Fontaine a Frontend Maintainer