Skip to content

Make Toon a MR coach

Toon Claes requested to merge tc-make-toon-mr-coach into master

I'd like to apply for MR coach.

Process

I didn't really find a real process about becoming one in the handbook, so I'm using a similar process as becoming Maintainer:

  1. Create an MR to add the maintainership to their team page entry.
  2. Explain in the MR body why they are ready to take on that responsibility.
  3. Use specific examples of recent "maintainer-level" reviews that they have performed.
    1. The MRs should not reflect only small changes to the code base, but also architectural ones and ones that create a full feature.
  4. Assign the MR to their manager and mention the existing maintainers of the relevant product (GitLab CE, GitLab EE, etc) and area (backend, frontend, etc.).

Also, these are the responsibilities listed on the MR coach job familes page:

Responsibilities

  • Go through all merge requests, assign the Community Contribution label to merge requests coming from the community, and triage them.
  • Close merge requests that we don't want, with a clear explanation on the reasons why, so that people don't feel discouraged.
  • Help contributors to get their merge requests to meet the contribution acceptance criteria.
  • If the contributor is unresponsive or if they are unable to finish it, finish their merge request to meet the contribution acceptance criteria:
    • Close the original merge request and say that you will finish it,
    • Check out the branch locally,
    • Keep at least one original commit (you can squash commits if there are a lot) from the author,
    • Make sure a changelog entry crediting the author exists,
    • Add your own commits to improve and finish the original work and
    • Push to a new branch and open a new merge request.
  • Make it easy to contribute to GitLab even for people who are new to Ruby, JavaScript, or programming entirely.

Motivation

  • I'm already subscribed to the ~"Community Contribution" label, and nearly at a daily basis looking at those MRs, reviewing them, or passing them along to other reviewers.
  • I'm also coaching people in the CC MR. One example: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22809#note_116889416
  • I'm already a GDK maintainer, which is useful for helping the wider community get started and troubleshoot GDK

Merge request reports