Skip to content

Draft: Add Daniele Bracciani as a backend maintainer

Daniele Braccianirequested to merge
daniele-gitlab-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

Contributions and evidence of thorough reviews

Daniele has been at GitLab for ~4mo, and has previously worked as Senior Software Engineer in a company using Ruby-on-Rails as their primary tech stack. At GitLab he has contributed to many parts of the stack including:

<Some examples here, Large table cleanup and so on...>

Some of the authored MRs:

<List of some nice MRs authored>

And some of reviewed MRs:

<List of some nice MRs reviewed>

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below and ask them to provide feedback to the manager directly. Emphasize that any negative feedback should be communicated privately to the manager/mentor, not in the merge request, as outlined in our maintainership feedback documentation.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Check this box to confirm that you approve the access provision.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT.

* If you have blocking feedback adhering [to the documentation](https://handbook.gitlab.com/handbook/engineering/workflow/code-review/#request-maintainership-feedback) please share it with me privately.
* If you are in agreement, and can vouch for this proposal, please approve.

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Remove yourself from maintainer_mentorship.yml and consider adding yourself as a maintainer mentor.
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to <project>/maintainers/backend with Owner access level.
  5. Announce it everywhere
  6. Familiarize yourself with documentation for Merging a merge request
  7. Keep reviewing, start merging 🤘 😎 🤘

Merge request reports