Skip to content

Fixes errors with the release post item generator

Chase Southard requested to merge fix_release_post_item_generator_rcs into master

Why is this change being made?

💡 Provide a detailed answer to the question on why this change is being proposed, in accordance with our value of Transparency.

Please add the details saying why, not just what in this section. Example: We have discussed the topic in Slack - (copy of Slack conversation). The current process is not efficient, this MR makes the description of X more clear, and helps move Y forward.

We recently introduced a Release Post feature enhancement to support addon badges, but in that process I introduced a critical typo was made backticks `` for quotes ''. 🤦

This resolve that error and fixes some other nil errors with older issues that fail to generate release post items as well.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Adds an early empty string return to avoid nil

  • Fixes add_ons key with quotes not backticks

  • Adds short circuit if raw_content is empty

The CONTENT_REGEX does not return enough lines in raw content to capture the documentation line number.

  • Adds permitted_class option for yaml parsing

  • fixes typo in release post description

Edited by Chase Southard

Merge request reports