Make Rad Batnag a backend maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. - Fix hash related changes for GraphQL upgrade (gitlab-org/gitlab!132958 - merged)
- Maven dependency proxy: handle gracefully netwo... (gitlab-org/gitlab!135956 - merged)
- Add ssh audit events (gitlab-org/gitlab!134556 - merged)
- Add count aggregation for projects with no DORA... (gitlab-org/gitlab!132516 - merged)
- Remove Gitlab.com check for ContainerRepository... (gitlab-org/gitlab!144917 - merged)
- Fix DiffStatsType encoding error (gitlab-org/gitlab!145068 - merged)
- Add Ci::RunnerManagersFinder (gitlab-org/gitlab!137888 - merged)
- Add instrumenting backend internal events to do... (gitlab-org/gitlab!136154 - merged)
- Use the registry tags API when fetching contain... (gitlab-org/gitlab!145397 - merged)
- Add Rubocop to enforce factories for new tables (gitlab-org/gitlab!146536 - merged)
- Remove Gitlab.com check when using GitlabApiCli... (gitlab-org/gitlab!152762 - merged)
-
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes. - Store metadata information when uploading a PyP... (gitlab-org/gitlab!131327 - merged)
- Display additional PyPi metadata info (gitlab-org/gitlab!136073 - merged)
- Dependency Proxy: Add group access token scope ... (gitlab-org/gitlab!136655 - merged)
- Refactor to pass personal access token scopes i... (gitlab-org/gitlab!149977 - merged)
- Add package_type validation to Packages::Compos... (gitlab-org/gitlab!110777 - merged)
- Optimize the query used to find NPM packages in... (gitlab-org/gitlab!114472 - merged)
- Do not include licenseText field in npm metadata (gitlab-org/gitlab!115846 - merged)
- Reduce spec flakiness (gitlab-org/gitlab!136069 - merged)
- Package Registry: Truncate Pypi metadata descri... (gitlab-org/gitlab!138449 - merged)
- Increase packages_pypi_metadata.keywords text l... (gitlab-org/gitlab!144983 - merged)
- Truncate Pypi package metadata fields (gitlab-org/gitlab!147891 - merged)
- Return an empty `pipelines` in the package REST... (gitlab-org/gitlab!150103 - merged)
- Fix Debian package flaky specs (gitlab-org/gitlab!154214 - merged)
- Refactor NPM metadata endpoint (gitlab-org/gitlab!154577 - merged)
@radbatnag has reviewed over 172 merged MRs and authored over 52 merged MRs
Trainee Backend Maintainer issue: https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/34062+
Backend Maintainer Mentor: @splattael
- Focuses on changes in MR and code quality 1, 2, 3, 4, 5, 6
- Cares about performance impact 1
- Encourages code readability and suggests re-use existing code when possible 1, 2, 3
- Identifies and suggests adding missing tests and improves test quality 1, 2, 3, 4
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty with the template below. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT.
* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement, and can vouch for this proposal, please approve.
After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.
Once This MR is Merged
-
Join the #backend_maintainers
Slack channel -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend
withOwner
access level. -
Announce it everywhere -
Familiarize yourself with documentation for Merging a merge request -
Keep reviewing, start merging 🤘 😎 🤘