Skip to content

Pin Vue.js version to 2.6.12

Vitaly Slobodin requested to merge vs/pin-vuejs-version into master

Why is this change being made?

The vue-loader package throws an error when it encounters version mismatch between vue and vue-template-compiler packages. Currently we specify the following constraint for the vue package: ~2.6.12. The tilde means it will match several versions: 2.6.12 and 2.6.14 as well but we pinned version for vue-template-compiler to 2.6.12. Any yarn command can update the vue package version to 2.6.14 and to avoid that we can pin it to `2.6.12.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Pin Vue.js version to 2.6.12

The vue-loader package throws an error when it encounters version mismatch between vue and vue-template-compiler packages. Currently we specify the following constraint for the vue package: ~2.6.12. The tilde means it will match several versions: 2.6.12 and 2.6.14 as well but we pinned version for vue-template-compiler to 2.6.12. Any yarn command can update the vue package version to 2.6.14 and to avoid that we can pin it to `2.6.12.


Edited by Vitaly Slobodin

Merge request reports