Add Sharmad Nachnolkar as a CDot FE maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
Related maintainership issue - Trainee FE maintainer (CustomersDot) - Sharmad ... (#13817 - closed)
Justification summary
- Working on CustomersDot project for 2+ years (first MR: https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/4270)
- Authored 107+ MRs
- Approved 49+ MRs (It seems like this filter doesn't show the MRs for which approval was reset because the author pushed some more commits - for eg. to fix conflicts, to address FE / BE / UX reviewer / maintainer changes etc. Ex this MR is not shown - https://gitlab.com/gitlab-org/customers-gitlab-com/-/merge_requests/9373)
- Based on the feedback collected for non-trivial MRs (in trainee maintainer issue), ~85% MRs were merged by the maintainer as-is without needing further changes from the author.
- Raises questions / provides suggestions in other areas like:
- Non-trivial reviews in CustomersDot:
- Non-trivial reviews in gitlab:
Note:
The ratio between reviewers/maintainers will change when we merge this MR. However, we already suggest to ask maintainers to also do initial reviews, so there should be no problem with this.
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org/<project>. -
Join the [at]frontend-maintainersslack group -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you togitlab-org/maintainers/frontendwithOwneraccess level. -
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Diana Zubova