Skip to content

Add Sheldon Led as a FE maintainer for GitLab

Sheldon Led requested to merge led/add-sheldonled-maintainer-gitlab into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as it is justified".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

Trainee Maintainer Issue: #34359 (closed).

Summary justification

MR Summary
gitlab-org/gitlab!129936 (merged) #34359 (comment 1662838453)
gitlab-org/gitlab!132939 (merged) #34359 (comment 1662840103)
gitlab-org/gitlab!130789 (merged) #34359 (comment 1662844280)
gitlab-org/gitlab!135447 (merged) #34359 (comment 1662848393)
gitlab-org/gitlab!145340 (merged) #34359 (comment 1909441230)
gitlab-org/gitlab!144778 (merged) #34359 (comment 1909450002)
gitlab-org/gitlab!148844 (merged) #34359 (comment 1909475978)

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.

Once This MR is Merged

  1. Create an access request for maintainer access to gitlab-org/gitlab
  2. Join the [at]frontend-maintainers slack group
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  4. Let a maintainer add you to gitlab-org/maintainers/frontend with Owner access level.
  5. Announce it everywhere
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Sheldon Led

Merge request reports