Skip to content

Enable validate-release-post-item script to run the same with or without bundle exec

Chase Southard requested to merge release_post_validation_fix_part2 into master

Why is this change being made?

💡 Provide a detailed answer to the question on why this change is being proposed, in accordance with our value of Transparency.

Please add the details saying why, not just what in this section. Example: We have discussed the topic in Slack - (copy of Slack conversation). The current process is not efficient, this MR makes the description of X more clear, and helps move Y forward.

We ran into some trouble after updating the validate-release-post-item script. Running the bin script without bundle exec gave different results than running with bundle exec. This change includes the requirement calling "bundler/setup" at the top of the script to force the bundled library environment.

This also allows us to remove the permitted_classes keyword in YAML.load_file calls. We'll have to deal with this eventually upon upgrading Ruby versions to 3.1 and/or Middleman version to 4.5

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Commits

  • Adds bundler/setup requirement

This should help make localhost and CI more consistent when running with or without bundle exec

  • Add yaml requirement; remove permitted_class
Edited by Chase Southard

Merge request reports