Skip to content

Fix failure on release post items without a tier

Chase Southard requested to merge fix_update_releases_servive_for_nil_tiers into master

Why is this change being made?

💡 Provide a detailed answer to the question on why this change is being proposed, in accordance with our value of Transparency.

After the 16.11 Release Post was published we should have updated https://gitlab.com/gitlab-org/gitlab/-/releases with the contents of highlights from the 16.11 release.

However, we used a newer release post item feature type beta. The structure of the beta release post item does not have an available_in key value pair.

This caused the following pipeline to fail: https://gitlab.com/gitlab-com/www-gitlab-com/-/jobs/6661470378

@afontaine and I looked into the failure and agreed that the missing tier (nil value for the highlight) was the root cause.

This MR introduces:

  • a guard clause at the get_highlight_tier method to return "other" when the tier is nil
  • the rejection of highlights where available_in (tier) is nil

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Chase Southard

Merge request reports